HomePhabricator

[backport#17070] wallet: Avoid showing GUI popups on RPC errors

Description

[backport#17070] wallet: Avoid showing GUI popups on RPC errors

Summary:
wallet: Avoid showing GUI popups on RPC errors (MarcoFalke)

Pull request description:

RPC errors and warnings are shown as popups in the GUI instead of being returned to the RPC caller. For example,

```
$ ./src/bitcoin-cli loadwallet $(pwd)/./test/functional/data/wallets/high_minversion/
error code: -4
error message:
Wallet loading failed.
```

gives me a GUI popup and no reason why loading the wallet failed.

After this pull request:

```
$ ./src/bitcoin-cli loadwallet $(pwd)/./test/functional/data/wallets/high_minversion/
error code: -4
error message:
Wallet loading failed: Error loading /home/marco/workspace/btc_bitcoin_core/./test/functional/data/wallets/high_minversion/wallet.dat: Wallet requires newer version of Bitcoin Core

https://github.com/bitcoin/bitcoin/pull/17070/commits/facec1c643105d0ae74b5d32cf33d593f9e82a36


Depends on D7106

Backport of Core PR17070

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7111

Details

Provenance
Wladimir J. van der Laan <laanwj@protonmail.com>Authored on Oct 21 2019, 11:47
majcostaCommitted on Aug 3 2020, 15:16
majcostaPushed on Aug 3 2020, 15:16
Reviewer
Restricted Project
Differential Revision
D7111: [backport#17070] wallet: Avoid showing GUI popups on RPC errors
Parents
rABCa87a2f00aec6: [backport#15450 5/5] Add Create Wallet menu action
Branches
Unknown
Tags
Unknown