HomePhabricator

Fix ZapSelectTx to sync wallet spends

Description

Fix ZapSelectTx to sync wallet spends

Summary:
PR18850:

The motivation is mapWallet is used, in many places, without check (method at expects that hash presents) but that's not exactly true when mapTxSpends and mapWallet are out of sync. That can lead to crash/data loss in wallet.

PR19493 fixes clang build on Mac OS

This is a backport of core#18850 and core#19493

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9989

Details

Provenance
Anthony Fieroni <bvbfan@abv.bg>Authored on May 2 2020, 09:28
PiRKCommitted on Aug 31 2021, 12:57
PiRKPushed on Aug 31 2021, 12:57
Reviewer
Restricted Project
Differential Revision
D9989: Fix ZapSelectTx to sync wallet spends
Parents
rABC28f40cef1710: cli: reduce DefaultRequestHandler memory allocations
Branches
Unknown
Tags
Unknown