HomePhabricator

[land-bot] Give a reasonable error when a revision cannot be found

Description

[land-bot] Give a reasonable error when a revision cannot be found

Summary:
Attempting to land-via-bot on a branch/commit with no revision results
in a not-useful error message. This patch ensures a comprehensible message is
provided instead.

Depends on D7959

Test Plan:
On clean master, author a commit and then cherry-pick this patch. The following
commands should give reasonable error messages:

arc land-via-bot --preview HEAD~
arc land-via-bot --hold HEAD~

On clean master:

git checkout <this-patch> arcanist/workflow/ArcanistLandBotWorkflow.php
git commit -m "Test commit with no revision information"

The following commands should give reasonable error messages:

arc land-via-bot --preview
arc land-via-bot --hold

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D7963

Details

Provenance
jasonbcoxAuthored on Fri, Oct 16, 19:13
abc-botPushed on Fri, Oct 16, 19:18
Reviewer
Restricted Project
Differential Revision
D7963: [land-bot] Give a reasonable error when a revision cannot be found
Parents
rABC9306dc3d8e81: [land-bot] Allow users to specify the branch/commit in order to determine theā€¦
Branches
Unknown
Tags
Unknown