HomePhabricator

[backport] gui: Show messages as text not html

Authored by Wladimir J. van der Laan <laanwj@gmail.com> on Mar 6 2018, 19:26.

Description

[backport] gui: Show messages as text not html

Summary:
6fbc0986f gui: Show messages as text not html (Wladimir J. van der Laan)


Pull request description:

Currently, error messages (such as InitError) are displayed as-is, which means Qt does auto detection on the format.

This means that it's possible to inject HTML from the command line though e.g. specifying a wallet name with HTML in it. This isn't a direct security risk because fetching content from internet is disabled (and as far as I know we never report strings received from the network this way). However, it can be confusing.

So explicitly force the format as text.


This is a backport from Core PR12617 (https://github.com/bitcoin/bitcoin/pull/12617)

Test Plan:

ninja check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4761

Details

Committed
majcostaDec 18 2019, 21:27
Pushed
majcostaDec 18 2019, 21:28
Reviewer
Restricted Owners Package
Differential Revision
D4761: [backport] gui: Show messages as text not html
Parents
rABCd7be9aa41479: Fix -Wcast-align in crypto_hash.cpp
Branches
Unknown
Tags
Unknown

Event Timeline