HomePhabricator

[chronik-client] Install ecashaddrjs from npm for published version

Description

[chronik-client] Install ecashaddrjs from npm for published version

Summary:
The installation of monorepo-managed dependencies directly from the monorepo is best for CI testing and making sure that all monorepo apps and dependencies are always using (and working with) the latest version of monorepo-maintained dependencies.

However, a typical user installing a monorepo-managed dependency from npm will not get these relative installs and will need to install them manually as peer dependencies. This is not documented and we have at least one report of it not working anyway.

Test Plan:
This builds locally. I followed these steps not in docker to publish an rc version, which a user reporting the issue said he was able to install and use successfully.

docker build -f chronik-client.Dockerfile -t chronik-client_local .

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16815

Details

Provenance
bytesofmanAuthored on Sep 25 2024, 22:34
bytesofmanPushed on Oct 2 2024, 13:04
Reviewer
Restricted Project
Differential Revision
D16815: [chronik-client] Install ecashaddrjs from npm for published version
Parents
rABCc97fa359ed0e: [ecash-agora] Add `historicOffers` function to `Agora`
Branches
Unknown
Tags
Unknown