HomePhabricator

[backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp

Description

[backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp

Summary:
There's no need to have this member live on CChainState since it's only used
in validation.cpp.

https://github.com/bitcoin/bitcoin/pull/16194/commits/55d525ab9004631d30dcc60a1ec5d9cd6c6afe56


Depends on D6967

Partial backport of Core PR16194

Test Plan:

ninja check && ninja check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6968

Details

Provenance
James O'Beirne <james.obeirne@gmail.com>Authored on Jun 24 2019, 17:57
majcostaCommitted on Sep 22 2020, 23:54
majcostaPushed on Sep 22 2020, 23:54
Reviewer
Restricted Project
Differential Revision
D6968: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp
Parents
rABC3e68843ee4f0: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex
Branches
Unknown
Tags
Unknown