HomePhabricator

[backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459…

Description

[backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137.

Summary:
CVE-2018-17144 and CVE-2012-2459 are only partially tested for regression.

  • CVE-2018-17144 is not tested for the inflation bug.
  • CVE-2012-2459 is only tested for the mutated block being rejected, not

for the original block being accepted afterwards.

This commit fixes that limitation.

Also added functional test for CVE-2010-5137.

This concludes backport of PR14696 - part 2 of 2
Depends on D8018

Test Plan: ninja && test/functional/test_runner.py p2p_invalid_block.py p2p_invalid_tx.py

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox, deadalnix

Subscribers: deadalnix, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8026

Details

Provenance
lucash-dev <lucash.dev@gmail.com>Authored on Oct 24 2020, 13:22
PiRKCommitted on Oct 24 2020, 13:22
abc-botPushed on Oct 24 2020, 13:27
Reviewer
Restricted Owners Package
Differential Revision
D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137.
Parents
rABC1fd789f3dea0: Make SignatureExtractorChecker private to its own file
Branches
Unknown
Tags
Unknown