HomePhabricator

Remove m_is_manual_connection from CNodeState

Description

Remove m_is_manual_connection from CNodeState

Summary:
Currently, this member is only used to exclude MANUAL peers from discouragement
in MaybePunishNodeForBlock(). Manual connections are already protected in
MaybeDiscourageAndDisconnect(), independently from their network
processing behaviors.

This is a backport of core#20617

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10946

Details

Provenance
Antoine Riard <ariard@student.42.fr>Authored on Dec 10 2020, 17:47
PiRKCommitted on Feb 1 2022, 12:12
PiRKPushed on Feb 1 2022, 12:12
Reviewer
Restricted Project
Differential Revision
D10946: Remove m_is_manual_connection from CNodeState
Parents
rABCb9ceb82661aa: p2p, rpc, test: address rate-limiting follow-ups
Branches
Unknown
Tags
Unknown