HomePhabricator

Set seeder user agent in a similar way to the node

Description

Set seeder user agent in a similar way to the node

Summary:
This enables these args in the seeder:

  • -uaclientname defaults to "Bitcoin ABC"
  • -uaclientversion defaults to the current ABC version

The comments section indicates the user agent is a seeder.

Old useragent: /bitcoin-cash-seeder:0.15/
New useragent: /Bitcoin ABC:0.24.2(seeder)/

Test Plan:

ninja bitcoind bitcoin-cli bitcoin-seeder check-seeder
./src/bitcoind
./src/seeder/bitcoin-seeder -overridednsseed=localhost
./src/bitcoin-cli getpeerinfo | grep subver

output:

"subver": "/Bitcoin ABC:0.23.8(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.2(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.2(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.7(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.8(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.3(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.2(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.8(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.4(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.8(EB32.0)/",
"subver": "/Bitcoin ABC:0.23.8(EB32.0)/",
"subver": "/Bitcoin ABC:0.24.0(EB32.0)/",
"subver": "/Bitcoin ABC:0.24.2(seeder)/",

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10105

Details

Provenance
thonkleAuthored on Mon, Sep 13, 04:35
thonklePushed on Tue, Sep 14, 17:51
Reviewer
Restricted Owners Package
Differential Revision
D10105: Set seeder user agent in a similar way to the node
Parents
rABCc556163d76e2: Rebrand seeder to eCash
Branches
Unknown
Tags
Unknown