HomePhabricator

ProcessOrphanTx: remove useless done variable

Description

ProcessOrphanTx: remove useless done variable

Summary:

There is a keyword that allows us to break out of loops. Use it.

There's a small change in behaviour here: if we process multiple orphans
that are still orphans, then we'll only call mempool.check() once at the
end, instead of after processing each tx.

This is a backport of core#19498 [2/5]
https://github.com/bitcoin/bitcoin/pull/19498/commits/55c79a9cefb6c83cdebbf6c538c471607695b457

Depends on D10412

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D10413

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Jun 25 2020, 19:37
PiRKCommitted on Nov 3 2021, 07:06
PiRKPushed on Nov 3 2021, 07:06
Reviewer
Restricted Project
Differential Revision
D10413: ProcessOrphanTx: remove useless done variable
Parents
rABCac7a1c69960f: [net processing] Add doxygen comments for orphan data and function
Branches
Unknown
Tags
Unknown