HomePhabricator

[tests] Add uacomment tests

Description

[tests] Add uacomment tests

Summary:
Checks for setting the value, max length and reserved characters.
The backported test has been modified to match our method, not throwing
exception but truncating and sanitizing the comment.

Backport of core PR11486

Depends on D2275

Test Plan:

./test/functional/test_runner.py uacomment

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox, teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2276

Details

Provenance
Cristian Mircea Messel <mess110@gmail.com>Authored on Oct 11 2017, 19:56
FabienCommitted on Jan 15 2019, 19:57
FabienPushed on Jan 15 2019, 19:57
Reviewer
Restricted Project
Differential Revision
D2276: [tests] Add uacomment tests
Parents
rABCdb4aa8ecde0a: Fix user agent sanitizer
Branches
Unknown
Tags
Unknown

Event Timeline

Fabien committed rABC44a2098ca3f5: [tests] Add uacomment tests (authored by Cristian Mircea Messel <mess110@gmail.com>).Jan 15 2019, 19:57