[linter] Remove and disallow js commented code
45b927480cc4
Actions

Description

[linter] Remove and disallow js commented code

Summary:
Commented code should be either uncommented or removed.

Depends on D12926.

Test Plan:

arc lint --everything

Reviewers: #bitcoin_abc, bytesofman

Reviewed By: #bitcoin_abc, bytesofman

Subscribers: bytesofman

Differential Revision: https://reviews.bitcoinabc.org/D12929

Details

Provenance

Fabien	Authored on Dec 20 2022, 16:17
Fabien	Pushed on Dec 21 2022, 13:15

Reviewer

Restricted Project

Differential Revision

D12929: [linter] Remove and disallow js commented code

Parents

rABC720673f17077: [linter] Use eslint to lint the javascript files

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABC45b927480cc4: [linter] Remove and disallow js commented code (authored by Fabien).Dec 21 2022, 13:15

Fabien added an edge: D12929: [linter] Remove and disallow js commented code.

teamcity mentioned this in T2891: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken..Dec 21 2022, 13:36

Changes (21)

Path

Size

web/

cashtab/

.eslintrc.js

config/

webpack.config.js

extension/

src/

contentscript.js

package-lock.json

package.json

src/

components/

Airdrop/

__tests__/

__snapshots__/

Airdrop.test.js.snap

Common/

ScanQRCode.js

Home/

__tests__/

__snapshots__/

Home.test.js.snap

Receive/

__tests__/

__snapshots__/

Receive.test.js.snap

Send/

Send.js

SendToken.js

__tests__/

__snapshots__/

Send.test.js.snap

SignVerifyMsg/

__tests__/

__snapshots__/

SignVerifyMsg.test.js.snap

Tokens/

CreateTokenForm.js

__tests__/

__snapshots__/

Tokens.test.js.snap

hooks/

useWallet.js

useWebAuthentication.js

utils/

__mocks__/

__tests__/

rABC45b927480cc4

View Options

web/cashtab/.eslintrc.js

View Options

web/cashtab/config/webpack.config.js

View Options

web/cashtab/extension/src/contentscript.js

View Options

web/cashtab/package-lock.json

View Options

web/cashtab/package.json

View Options

web/cashtab/src/components/Airdrop/tests/snapshots/Airdrop.test.js.snap

View Options

web/cashtab/src/components/Common/ScanQRCode.js

View Options

web/cashtab/src/components/Home/tests/snapshots/Home.test.js.snap

View Options

web/cashtab/src/components/Receive/tests/snapshots/Receive.test.js.snap

View Options

web/cashtab/src/components/Send/Send.js

View Options

web/cashtab/src/components/Send/SendToken.js

View Options

web/cashtab/src/components/Send/tests/snapshots/Send.test.js.snap

View Options

web/cashtab/src/components/SignVerifyMsg/tests/snapshots/SignVerifyMsg.test.js.snap

View Options

web/cashtab/src/components/Tokens/CreateTokenForm.js

View Options

web/cashtab/src/components/Tokens/tests/snapshots/Tokens.test.js.snap

View Options

web/cashtab/src/hooks/useWallet.js

View Options

web/cashtab/src/hooks/useWebAuthentication.js

View Options

web/cashtab/src/utils/GoogleAnalytics.js

View Options

web/cashtab/src/utils/mocks/mockTxBuilderObj.js

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/cashMethods.js

[linter] Remove and disallow js commented code45b927480cc4Actions

Description

Details

Event Timeline

Changes (21)

rABC45b927480cc4

web/cashtab/.eslintrc.js

web/cashtab/config/webpack.config.js

web/cashtab/extension/src/contentscript.js

web/cashtab/package-lock.json

web/cashtab/package.json

web/cashtab/src/components/Airdrop/__tests__/__snapshots__/Airdrop.test.js.snap

web/cashtab/src/components/Common/ScanQRCode.js

web/cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

web/cashtab/src/components/Receive/__tests__/__snapshots__/Receive.test.js.snap

web/cashtab/src/components/Send/Send.js

web/cashtab/src/components/Send/SendToken.js

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

web/cashtab/src/components/SignVerifyMsg/__tests__/__snapshots__/SignVerifyMsg.test.js.snap

web/cashtab/src/components/Tokens/CreateTokenForm.js

web/cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap

web/cashtab/src/hooks/useWallet.js

web/cashtab/src/hooks/useWebAuthentication.js

web/cashtab/src/utils/GoogleAnalytics.js

web/cashtab/src/utils/__mocks__/mockTxBuilderObj.js

web/cashtab/src/utils/__tests__/cashMethods.test.js

web/cashtab/src/utils/cashMethods.js

[linter] Remove and disallow js commented code
45b927480cc4
Actions

web/cashtab/src/components/Airdrop/tests/snapshots/Airdrop.test.js.snap

web/cashtab/src/components/Home/tests/snapshots/Home.test.js.snap

web/cashtab/src/components/Receive/tests/snapshots/Receive.test.js.snap

web/cashtab/src/components/Send/tests/snapshots/Send.test.js.snap

web/cashtab/src/components/SignVerifyMsg/tests/snapshots/SignVerifyMsg.test.js.snap

web/cashtab/src/components/Tokens/tests/snapshots/Tokens.test.js.snap

web/cashtab/src/utils/mocks/mockTxBuilderObj.js

web/cashtab/src/utils/tests/cashMethods.test.js