Paths

Table of Contentst

Diffusion Bitcoin ABC 47a5b8aad9e2

Replace std::to_string with locale-independent alternative
47a5b8aad9e2
Actions

Description

Replace std::to_string with locale-independent alternative

Summary:

std::to_string relies on the current locale for formatting purposes

This is a backport of Core PR18134 and PR17851

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien, majcosta

Reviewed By: #bitcoin_abc, Fabien, majcosta

Subscribers: majcosta, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8878

Details

Provenance

Ben Woosley <ben.woosley@gmail.com>	Authored on Jan 12 2021, 16:00
PiRK	Committed on Jan 12 2021, 16:01
abc-bot	Pushed on Jan 12 2021, 16:05

Reviewer

Restricted Project

Differential Revision

D8878: Replace std::to_string with locale-independent alternative

Parents

rABC6a46b5411203: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing…

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABC47a5b8aad9e2: Replace std::to_string with locale-independent alternative (authored by Ben Woosley <ben.woosley@gmail.com>).Jan 12 2021, 16:01

PiRK added an edge: D8878: Replace std::to_string with locale-independent alternative.Jan 12 2021, 16:06

Changes (22)

Path

Size

arcanist/

linter/

LocaleDependenceLinter.php

src/

qt/

rpc/

test/

excessiveblock_tests.cpp

transaction_tests.cpp

util/

setup_common.h

util_tests.cpp

util_threadnames_tests.cpp

util/

string.h

wallet/

scriptpubkeyman.cpp

rABC47a5b8aad9e2

View Options

arcanist/linter/LocaleDependenceLinter.php

View Options

src/bitcoin-tx.cpp

View Options

src/core_read.cpp

View Options

src/qt/optionsmodel.cpp

View Options

src/rpc/abc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/util.cpp

View Options

src/test/addrman_tests.cpp

View Options

src/test/blockchain_tests.cpp

View Options

src/test/excessiveblock_tests.cpp

View Options

src/test/key_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/net_tests.cpp

View Options

src/test/settings_tests.cpp

View Options

src/test/timedata_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/util/setup_common.h

View Options

src/test/util_tests.cpp

View Options

src/test/util_threadnames_tests.cpp

View Options

src/util/string.h

View Options

src/wallet/scriptpubkeyman.cpp

Replace std::to_string with locale-independent alternative47a5b8aad9e2Actions

Description

Details

Event Timeline

Changes (22)

rABC47a5b8aad9e2

arcanist/linter/LocaleDependenceLinter.php

src/bitcoin-tx.cpp

src/core_read.cpp

src/qt/optionsmodel.cpp

src/rpc/abc.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/rpc/util.cpp

src/test/addrman_tests.cpp

src/test/blockchain_tests.cpp

src/test/excessiveblock_tests.cpp

src/test/key_tests.cpp

src/test/miner_tests.cpp

src/test/net_tests.cpp

src/test/settings_tests.cpp

src/test/timedata_tests.cpp

src/test/transaction_tests.cpp

src/test/util/setup_common.h

src/test/util_tests.cpp

src/test/util_threadnames_tests.cpp

src/util/string.h

src/wallet/scriptpubkeyman.cpp

Replace std::to_string with locale-independent alternative
47a5b8aad9e2
Actions