HomePhabricator

tests: add feature_bind_port_*.py to EXTRA_PRIVILEGES_TESTS

Description

tests: add feature_bind_port_*.py to EXTRA_PRIVILEGES_TESTS

Summary:
This two tests need root privileges to set-up a local loop network.
They are normally skipped on CI, and are currently breaking the script that
updates the timing.json file. Adding them to EXTRA_PRIVILEGES_TESTS will
let this script skip them and complete successfully.

Test Plan:

cd test/functional/
NON_TESTS=$(python3 -c 'from test_runner import NON_SCRIPTS; print(" ".join(NON_SCRIPTS))')
export NON_TESTS
EXTRA_PRIVILEGES_TESTS=$(python3 -c 'from test_runner import EXTRA_PRIVILEGES_TESTS; print(" ".join(EXTRA_PRIVILEGES_TESTS))')
export EXTRA_PRIVILEGES_TESTS

check_missing() {
  # Exclude non-tests from the check
  if [[ "${NON_TESTS}" =~ $1 ]] || [[ "${EXTRA_PRIVILEGES_TESTS}" =~ $1 ]]; then
    exit 0
  fi

  if ! grep -q $1 timing.json ; then
    echo "Error: Test file '$1' is missing from timing.json"
    exit 1
  fi
}
export -f check_missing
find . -maxdepth 1 -name '*.py' | cut -c 3- | xargs -I'{}' -n1 bash -c 'check_missing {}'

Check that these two functional tests are not listed as missing from timing.json

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D14715

Details

Provenance
PiRKAuthored on Oct 31 2023, 18:37
PiRKPushed on Nov 1 2023, 16:54
Reviewer
Restricted Project
Differential Revision
D14715: tests: add feature_bind_port_*.py to EXTRA_PRIVILEGES_TESTS
Parents
rABCaf056c1e9a7d: [e.cash] Bump version to 0.28.2 on upgrade page
Branches
Unknown
Tags
Unknown