HomePhabricator

Merge #14208: [build] Actually remove ENABLE_WALLET

Description

Merge #14208: [build] Actually remove ENABLE_WALLET

Summary:
e4ef4b459548b4032b9da03b3103525f935acb82 [build] remove #ifdef ENABLE_WALLET from interfaces/node (John Newbery)

Pull request description:

Adds a couple of redefinitions to dummywallet.cpp.

Tree-SHA512: d226bcccc46d089eac88beb54c31f6f18817682994b371f9793a5d28bec5d60dbdffacc8fc281807e25cc7f89da23e1f8f36fd99d12f8a40f77a972840e8c1b4

Backport of Core PR14208

Test Plan:

cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
ninja
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli getnewaddress

Verify rpc fails because there is no wallet.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5518

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Sep 13 2018, 13:46
nakihitoCommitted on Mar 20 2020, 20:10
nakihitoPushed on Mar 20 2020, 20:10
Reviewer
Restricted Owners Package
Differential Revision
D5518: Merge #14208: [build] Actually remove ENABLE_WALLET
Parents
rABCf7352a1260f0: build: set minimum supported macOS to 10.12
Branches
Unknown
Tags
Unknown