HomePhabricator

[tests] allow tests to be run with --usecli

Description

[tests] allow tests to be run with --usecli

Summary:
test_framework accepts a new --usecli parameter. Running the test with
this parameter will cause all RPCs to be sent through bitcoin-cli rather
than directly over http. By default, individual test cases do not
support --usecli, and self.supports_cli must be set to True in the
set_test_params method.

We can make supports_cli default to True in future once we know which
tests will fail with use_cli.

Partial backport of core PR11970 (commit f6ade9c)

Depends on D2398

Test Plan:

./test/functional/test_runner.py interface_bitcoin_cli

./test/functional/test_runner.py --usecli interface_bitcoin_cli

Check it gets skipped

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2399

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Jul 11 2017, 17:14
FabienCommitted on Jan 24 2019, 17:12
FabienPushed on Jan 24 2019, 17:12
Reviewer
Restricted Project
Differential Revision
D2399: [tests] allow tests to be run with --usecli
Parents
rABC409c29a95ae1: TestNodeCLI batch emulation
Branches
Unknown
Tags
Unknown

Event Timeline