HomePhabricator

index: Improve robustness of coinstatsindex at restart

Description

index: Improve robustness of coinstatsindex at restart

Summary:

This change lets the coinstatsindex fail loudly in case the internal muhash state differs from the last finalized output saved on disk, which would indicate that the muhash state somehow got out of sync. This should generally not happen since both are written to disk in a batch but core#24076 seems to indicate that the might still be an issue.

Note that the actual fix for the mentionned issue is not in this backport. It is in core#24138.

This is a backport of core#24133

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D13911

Details

Provenance
Fabian Jahr <fjahr@protonmail.com>Authored on Jan 23 2022, 00:55
PiRKCommitted on May 18 2023, 07:59
PiRKPushed on May 18 2023, 07:59
Reviewer
Restricted Project
Differential Revision
D13911: index: Improve robustness of coinstatsindex at restart
Parents
rABC45959e9b2166: [Automated] Update timing.json
Branches
Unknown
Tags
Unknown