HomePhabricator

key.cpp: fail with a friendlier message on missing ssl EC support
4a09e1df5126Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

key.cpp: fail with a friendlier message on missing ssl EC support

Previously if bitcoind is linked with an OpenSSL which is compiled
without EC support, this is seen as an assertion failure "pKey !=
NULL" at key.cpp:134, which occurs after several seconds. It is an
esoteric piece of knowledge to interpret this as "oops, I linked
with the wrong OpenSSL", and because of the delay it may not even
be noticed.

The new output is

: OpenSSL appears to lack support for elliptic curve cryptography. For
more information, visit
https://en.bitcoin.it/wiki/OpenSSL_and_EC_Libraries
: Initialization sanity check failed. Bitcoin Core is shutting down.

which occurs immediately after attempted startup.

This also blocks in an InitSanityCheck() function which currently only
checks for EC support but should eventually do more. See #4081.

Details

Provenance
Andrew Poelstra <asp11@sfu.ca>Authored on Jun 2 2014, 23:21
deadalnixPushed on May 14 2017, 22:04
Parents
rABC52d7a544342b: Merge pull request #3683
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Poelstra <asp11@sfu.ca> committed rABC4a09e1df5126: key.cpp: fail with a friendlier message on missing ssl EC support (authored by Andrew Poelstra <asp11@sfu.ca>).Jun 3 2014, 19:09