HomePhabricator

GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing

Description

GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing

Summary:
Backport of core PR17474.

This has been adapted to match our codebase changes from core.
It introduces one change to the way the unknown service bits are displayed,
to make them consistenly display as a bit number. This matches what core does
when the backports are up-to-date and makes the code simpler.

Test Plan:

ninja check

./src/qt/bitcoin-qt

Check the service bit display correctly.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8516

Details

Provenance
Luke Dashjr <luke-jr+git@utopios.org>Authored on Nov 14 2019, 04:50
FabienCommitted on Nov 25 2020, 16:41
FabienPushed on Nov 25 2020, 16:43
Reviewer
Restricted Project
Differential Revision
D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing
Parents
rABC8788c6978ca6: Drop the BITCOIN_CASH service bit
Branches
Unknown
Tags
Unknown

Event Timeline