HomePhabricator

Add regtests for HTTP status codes.

Description

Add regtests for HTTP status codes.

Summary:
PR description:

This adds explicit tests for the returned HTTP status codes to
interface_rpc.py (for error cases) and the HTTP JSON-RPC client in
general for success.

PR15381 brought up discussion about the HTTP status codes in general,
and the general opinion was that the current choice may not be ideal
but should not be changed to preserve compatibility with existing
JSON-RPC clients. Thus it makes sense to actually test the current
status to ensure this desired compatibility is not broken accidentally.

This is a backport of Core PR15495

Test Plan: ninja && test/functional/test_runner.py interface_rpc

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7752

Details

Provenance
Daniel Kraft <d@domob.eu>Authored on Feb 27 2019, 14:37
PiRKCommitted on Oct 5 2020, 13:46
PiRKPushed on Oct 5 2020, 13:47
Reviewer
Restricted Owners Package
Differential Revision
D7752: Add regtests for HTTP status codes.
Parents
rABC448f8396b67d: Remove unused var
Branches
Unknown
Tags
Unknown