HomePhabricator

[avalanche] Use a consistent and well known proof master in proof tests

Description

[avalanche] Use a consistent and well known proof master in proof tests

Summary:
The private key associated with the proof master for some test vectors is unknown. This makes it impossible to introduce the proof signature without having to change this key, which this diff does. This makes it easier to review the changes when the proof signature is introduced.

Since changing the proof master will change the proof id, the vectors where the verification result is expected to be valid needs to update the stake signature as well.

The review may show a lot of changes for some vectors because they were using an uncompressed pubkey, and the new one is compressed causing the hex to get unaligned.

Ref T1676.

Test Plan:

ninja check-avalanche-proof_tests

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Subscribers: PiRK

Maniphest Tasks: T1676

Differential Revision: https://reviews.bitcoinabc.org/D10300

Details

Provenance
FabienAuthored on Oct 11 2021, 12:55
FabienPushed on Oct 12 2021, 08:54
Reviewer
Restricted Project
Differential Revision
D10300: [avalanche] Use a consistent and well known proof master in proof tests
Parents
rABC5f07cb78e850: [avalanche] Limit the number of inflight proof poll requests
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task