HomePhabricator

Avoid std::locale/imbue in DateTimeStrFormat

Authored by Pieter Wuille <pieter.wuille@gmail.com> on Apr 13 2018, 05:31.

Description

Avoid std::locale/imbue in DateTimeStrFormat

Summary:

And replace them with just hardcoded ISO8601 strings and gmtime_r.

Pointed out by @laanwj here: #12970 (comment)

Backport of core PR12973 and PR13031
https://github.com/bitcoin/bitcoin/pull/12973/files
https://github.com/bitcoin/bitcoin/pull/13031/files

The build for MSVC is left untested and just backported "as-is". AFAIK
we don't support MSVC build and have no plan to do so, but in the event
this should occur in the future that part of code will be ready.

Test Plan:

make check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3649

Details

Committed
FabienThu, Jul 11, 20:03
Pushed
FabienThu, Jul 11, 20:03
Reviewer
Restricted Project
Differential Revision
D3649: Avoid std::locale/imbue in DateTimeStrFormat
Parents
rABCda3dc9f3f909: [wallet] Add CWallet::Verify function
Branches
Unknown
Tags
Unknown

Event Timeline