HomePhabricator

Decodehextx scripts sanity check

Authored by Andrew Chow <achow101-github@achow101.com> on May 30 2017, 22:42.

Description

Decodehextx scripts sanity check

Summary:

  • Add a valid opcode sanity check to CScript

Added a function in CScript that checks if the script contains valid opcodes.

Add a test for that function

  • Sanity check transaction scripts in DecodeHexTx

Make sure that the scripts of decoded transactions are valid scripts.

This is a backport of Core PR10481

This include a bugfix to the integration test suite, as bogous transactions where generated in there.

Test Plan:

make check
./test/functional/test_runner.py --extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4247

Details

Committed
deadalnixOct 14 2019, 16:02
Pushed
deadalnixOct 14 2019, 16:02
Reviewer
Restricted Project
Differential Revision
D4247: Decodehextx scripts sanity check
Parents
rABCabb7cfc0104c: Update seeder files to use fprintf() instead of printf()
Branches
Unknown
Tags
Unknown

Event Timeline

deadalnix committed rABC4d6e498e3767: Decodehextx scripts sanity check (authored by Andrew Chow <achow101-github@achow101.com>).Oct 14 2019, 16:02