Paths

Table of Contentst

Diffusion Bitcoin ABC 4faf6bb42918

clang-tidy: Add `performance-inefficient-vector-operation` check
4faf6bb42918
Actions

Description

clang-tidy: Add performance-inefficient-vector-operation check

Summary:
https://clang.llvm.org/extra/clang-tidy/checks/performance/inefficient-vector-operation.html

This is a partial backport of core#26642

Depends on D18074

Test Plan: ninja all check-all bench-bitcoin

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D18075

Details

Provenance

Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>	Authored on Mar 26 2023, 19:17
PiRK	Committed on May 12 2025, 18:39
PiRK	Pushed on May 12 2025, 18:39

Reviewer

Restricted Project

Differential Revision

D18075: clang-tidy: Add `performance-inefficient-vector-operation` check

Parents

rABCfe1b2b8724d7: Fix clang-tidy readability-const-return-type violations

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABC4faf6bb42918: clang-tidy: Add `performance-inefficient-vector-operation` check (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).May 12 2025, 18:39

PiRK added an edge: D18075: clang-tidy: Add `performance-inefficient-vector-operation` check.

teamcity mentioned this in T3817: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken..May 12 2025, 18:51

teamcity mentioned this in T3818: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken..

teamcity mentioned this in T3819: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken..

Changes (19)

Path

Size

src/

.clang-tidy

avalanche/

test/

stakecontendercache_tests.cpp

bench/

rpc/

test/

script_p2sh_tests.cpp

txrequest_tests.cpp

util/

net.cpp

util_threadnames_tests.cpp

validation_block_tests.cpp

wallet/

bdb.cpp

rpc/

backup.cpp

scriptpubkeyman.cpp

rABC4faf6bb42918

View Options

src/.clang-tidy

View Options

src/avalanche/test/stakecontendercache_tests.cpp

View Options

src/bench/chained_tx.cpp

View Options

src/bench/coin_selection.cpp

View Options

src/bench/lockedpool.cpp

View Options

src/rpc/server.cpp

View Options

src/test/allocator_tests.cpp

View Options

src/test/getarg_tests.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/radix_tests.cpp

View Options

src/test/scheduler_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/txrequest_tests.cpp

View Options

src/test/util/net.cpp

View Options

src/test/util_threadnames_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/wallet/bdb.cpp

View Options

src/wallet/rpc/backup.cpp

View Options

src/wallet/scriptpubkeyman.cpp

clang-tidy: Add `performance-inefficient-vector-operation` check4faf6bb42918Actions

Description

Details

Event Timeline

Changes (19)

rABC4faf6bb42918

src/.clang-tidy

src/avalanche/test/stakecontendercache_tests.cpp

src/bench/chained_tx.cpp

src/bench/coin_selection.cpp

src/bench/lockedpool.cpp

src/rpc/server.cpp

src/test/allocator_tests.cpp

src/test/getarg_tests.cpp

src/test/mempool_tests.cpp

src/test/radix_tests.cpp

src/test/scheduler_tests.cpp

src/test/script_p2sh_tests.cpp

src/test/txrequest_tests.cpp

src/test/util/net.cpp

src/test/util_threadnames_tests.cpp

src/test/validation_block_tests.cpp

src/wallet/bdb.cpp

src/wallet/rpc/backup.cpp

src/wallet/scriptpubkeyman.cpp

clang-tidy: Add `performance-inefficient-vector-operation` check
4faf6bb42918
Actions