HomePhabricator

[net processing] Default initialize m_recent_confirmed_transactions

Description

[net processing] Default initialize m_recent_confirmed_transactions

Summary:
Now that m_recent_confirmed_transactions is owned by PeerManagerImpl,
and PeerManagerImpl's lifetime is managed by the node context, we can
just default initialize m_recent_confirmed_transactions during object
initialization. We can also remove the unique_ptr indirection.

This concludes backport of core#21562
https://github.com/bitcoin/bitcoin/pull/21562/commits/fde1bf4f6136638e84cdf9806eedaae08e841bbf

Depends on D13379

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D13380

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Mar 31 2021, 17:40
PiRKCommitted on Mar 21 2023, 06:51
PiRKPushed on Mar 21 2023, 06:51
Reviewer
Restricted Project
Differential Revision
D13380: [net processing] Default initialize m_recent_confirmed_transactions
Parents
rABCf8876a7d16ce: scripted-diff: Rename recentRejects
Branches
Unknown
Tags
Unknown