HomePhabricator

Copy the smart pointer rather then the raw tx when adding a mempool tx to the…

Description

Copy the smart pointer rather then the raw tx when adding a mempool tx to the wallet

Summary: This will allow for making CTransaction non copyable, and force the use of CTransactionRef so we only keep a single pointer to a transaction for all its uses through the codebase.

Test Plan:

ninja all check-all
./test/functional/test_runner.py wallet*
./contrib/teamcity/build-configurations.py build-asan

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Subscribers: PiRK

Differential Revision: https://reviews.bitcoinabc.org/D12916

Details

Provenance
FabienAuthored on Dec 19 2022, 17:49
FabienPushed on Dec 20 2022, 14:31
Reviewer
Restricted Project
Differential Revision
D12916: Copy the smart pointer rather then the raw tx when adding a mempool tx to the wallet
Parents
rABC0fe80ccc4d0b: [Cashtab] Improve vertical centering of QRCode in Receive.js
Branches
Unknown
Tags
Unknown