HomePhabricator

prevent peer flooding request queue for an inv
502969818644Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

prevent peer flooding request queue for an inv

mapAlreadyAskedFor does not keep track of which peer has a request queued for a
particular tx. As a result, a peer can blind a node to a tx indefinitely by
sending many invs for the same tx, and then never replying to getdatas for it.
Each inv received will be placed 2 minutes farther back in mapAlreadyAskedFor,
so a short message containing 10 invs would render that tx unavailable for 20
minutes.

This is fixed by disallowing a peer from having more than one entry for a
particular inv in mapAlreadyAskedFor at a time.

Details

Provenance
kazcw <keziahw@gmail.com>Authored on Jul 16 2014, 21:31
Gregory Maxwell <greg@xiph.org>Committed on Nov 23 2015, 01:18
deadalnixPushed on May 14 2017, 22:04
Parents
rABC0b0fc179ab87: Merge pull request #7028
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rABC502969818644: prevent peer flooding request queue for an inv (authored by kazcw <keziahw@gmail.com>).Nov 23 2015, 01:18