HomePhabricator

[Cashtab] Apply BigNumber to all base unit calcs in sendBch

Description

[Cashtab] Apply BigNumber to all base unit calcs in sendBch

Summary: Finalize the refactor of sendBch function away from toSatoshi methods and js math. Apply BigNumber library to remainder variable and adjust compare functions to use BigNumber methods. Add unit tests to demonstrate no change from previous function.

Test Plan: npm test

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9180

Details

Provenance
Joey King <joseph.roy.king@gmail.com>Authored on Feb 5 2021, 16:07
bytesofmanPushed on Feb 5 2021, 22:35
Reviewer
Restricted Project
Differential Revision
D9180: [Cashtab] Apply BigNumber to all base unit calcs in sendBch
Parents
rABC05d6cf91570b: Fix the deserialization of CoinEntry
Branches
Unknown
Tags
Unknown