HomePhabricator

track nSigChecks in CheckInputs

Description

track nSigChecks in CheckInputs

Summary:
This makes CheckInputs do the following:

  • If sigchecks are found in cache, return them.
  • If cache miss and checks are not deferred, then accumulate the total of inputs' sigchecks, store them in cache if requested, and then finally return those.
  • If cache miss and checks are deferred, return 0 sigchecks.

Depends on D4940 and D4834

Test Plan: ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Maniphest Tasks: T704

Differential Revision: https://reviews.bitcoinabc.org/D5126

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Feb 1 2020, 15:34
markblundebergPushed on Feb 2 2020, 04:01
Reviewer
Restricted Project
Differential Revision
D5126: track nSigChecks in CheckInputs
Parents
rABCaf65f22e4729: Fix missing lock in txvalidationcache_tests
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC5215dac06119: track nSigChecks in CheckInputs (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).Feb 2 2020, 04:01