HomePhabricator

[backport#14599] Use functions guaranteed to be locale independent

Description

[backport#14599] Use functions guaranteed to be locale independent

Summary:
Use IsDigit(...) instead of std::isdigit
Use ToLower(...) instead of std::tolower
Use IsSpace(...) instead of boost::is_space
Update KNOWN_VIOLATIONS: Remove fixed violations


Backport of Core PR14599

Test Plan:

ninja check

Reviewers: #bitcoin_abc, jasonbcox, deadalnix

Reviewed By: #bitcoin_abc, jasonbcox, deadalnix

Subscribers: deadalnix, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D6294

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Oct 29 2018, 08:13
majcostaCommitted on Jun 2 2020, 18:18
majcostaPushed on Jun 2 2020, 18:18
Reviewer
Restricted Project
Differential Revision
D6294: [backport#14599] Use functions guaranteed to be locale independent
Parents
rABC7ed7760657b5: [test] add a couple test cases to uint256_tests.cpp
Branches
Unknown
Tags
Unknown