HomePhabricator

DumpMempool: Pass in dump_path, stop using gArgs

Description

DumpMempool: Pass in dump_path, stop using gArgs

Summary:
Also introduce node::{ShouldPersistMempool,MempoolPath} helper functions
in node/mempool_persist_args.{h,cpp} which are used by non-kernel
DumpMempool callers to determine whether or not to automatically dump
the mempool and where to dump it to.

This is a partial backport of core#25487
https://github.com/bitcoin/bitcoin/pull/25487/commits/413f4bb52b72e082ad8716664ede48352b8e7e5a

Depends on D15716

Test Plan: ninja all check-all bitcoin-fuzzers

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15717

Details

Provenance
Carl Dong <contact@carldong.me>Authored on Jul 12 2022, 19:54
PiRKCommitted on Mar 18 2024, 15:16
PiRKPushed on Mar 18 2024, 15:16
Reviewer
Restricted Project
Differential Revision
D15717: DumpMempool: Pass in dump_path, stop using gArgs
Parents
rABC09d7c7ce2b96: DumpMempool: Use std::chrono instead of weird int64_t arthmetics
Branches
Unknown
Tags
Unknown