HomePhabricator

net_processing: move MaybeSetPeerAsAnnouncingHeadersAndIDs into PeerManagerImpl

Description

net_processing: move MaybeSetPeerAsAnnouncingHeadersAndIDs into PeerManagerImpl

Summary:
Allows making lNodesAnnouncingHeaderAndIDs and nPeersWithValidatedDownloads member vars instead of globals.
Removes the need to pass conman as a parameter to the method.

This concludes a backport of core#20942 [8&9/9]
https://github.com/bitcoin/bitcoin/pull/20942/commits/39c2a69bc28eb3e3b5fa15a3965773b459bbf7ad
https://github.com/bitcoin/bitcoin/pull/20942/commits/6452190841f8da1cdaf899d064974136ab37659f

Depends on D11436

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11437

Details

Provenance
PiRKAuthored on May 6 2022, 15:28
PiRKPushed on May 10 2022, 15:13
Reviewer
Restricted Project
Differential Revision
D11437: net_processing: move MaybeSetPeerAsAnnouncingHeadersAndIDs into PeerManagerImpl
Parents
rABCbc00297c37d9: net_processing: move FindTxForGetData and ProcessGetData to PeerManagerImpl
Branches
Unknown
Tags
Unknown