HomePhabricator

Skip hdKeypath of 'm'

Description

Skip hdKeypath of 'm'

Summary:

Previously the seed was stored with keypath 'm' so we need to skip this
as well when determining inactive seeds.

Partial backport of core PR19054:
https://github.com/bitcoin/bitcoin/pull/19054/commits/3a03a11e8c696e2164b8bb221a4a35a7c3ac4d6d

This unbreaks opening the wallets (since D9196) that were created before
D4175.

There is a second commit with an upgrade test which requires some work
to be ported.

Test Plan:

ninja all check-all

Checked I can now open my wallet.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9211

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on May 22 2020, 17:42
FabienCommitted on Feb 11 2021, 13:12
FabienPushed on Feb 11 2021, 13:14
Reviewer
Restricted Project
Differential Revision
D9211: Skip hdKeypath of 'm'
Parents
rABC5be9d5e9c482: addrman: ensure old versions don't parse peers.dat
Branches
Unknown
Tags
Unknown

Event Timeline

Fabien committed rABC5848be501e8b: Skip hdKeypath of 'm' (authored by Andrew Chow <achow101-github@achow101.com>).Feb 11 2021, 13:12
teamcity mentioned this in Unknown Object (Maniphest Task).Feb 11 2021, 13:46
teamcity mentioned this in Unknown Object (Maniphest Task).Feb 11 2021, 16:20