HomePhabricator

Stop treating importaddress'ed scripts as change
595b22e5c0bfUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Stop treating importaddress'ed scripts as change

Before this, if someone imported a scriptPubKey directly (in hex form) using
importaddress, outputs sending to it would be treated as change, as the
corresponding CTxDestination was not added to the address book.

Fix this by trying to detect scriptPubKeys that are in fact convertible to a
CTxDestination and add them anyway. Add a warning to the RPC help to warn
against importing raw non-standard scripts.

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Mar 14 2016, 17:55
deadalnixPushed on May 14 2017, 22:04
Parents
rABC7fa8d7585984: Merge #8112: Include signal.h for sig_atomic_t in WIN32
Branches
Unknown
Tags
Unknown

Event Timeline

Pieter Wuille <pieter.wuille@gmail.com> committed rABC595b22e5c0bf: Stop treating importaddress'ed scripts as change (authored by Pieter Wuille <pieter.wuille@gmail.com>).Jun 2 2016, 13:53