HomePhabricator

build: set Unicode true for NSIS installer

Description

build: set Unicode true for NSIS installer

Summary:

Now that we are using Focal for gitian builds, and have NSIS 3.0+
available (also in Guix), we can create installers that support unicode.

Unicode is only becoming the default beginning with the 3.07 release,
https://nsis.sourceforge.io/Docs/AppendixF.html#v3.07-cl,
so we need to set this attribute to get support.

Should close: #13817

On Debian 10 the nsis version is 3.04, so we should be able to use the
feature.

Backport of core#21333

Test Plan: Run the windows gitian build twice, ensure it's deterministic.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9318

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Mar 2 2021, 08:24
FabienCommitted on Mar 11 2021, 16:21
FabienPushed on Mar 11 2021, 16:24
Reviewer
Restricted Project
Differential Revision
D9318: build: set Unicode true for NSIS installer
Parents
rABCd22df03d41a7: doc: install qt5 when building on macOS
Branches
Unknown
Tags
Unknown