HomePhabricator

refactor: Move error() from util/system.h to logging.h

Description

refactor: Move error() from util/system.h to logging.h

Summary:
error is a low-level function with a sole dependency on LogPrintf, which
is defined in logging.h

The background of this commit is an ongoing effort to decouple the
libbitcoinkernel library from the ArgsManager defined in system.h.
Moving the function out of system.h allows including it from a separate
source file without including the ArgsManager definitions from system.h.

This concludes backport of core#27238
https://github.com/bitcoin/bitcoin/pull/27238/commits/aaced5633b81b2f08b993106a527e2a0e1d663c1

Depends on D16149

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16150

Details

Provenance
Ben Woosley <ben.woosley@gmail.com>Authored on Mar 6 2023, 21:01
PiRKCommitted on May 14 2024, 10:41
PiRKPushed on May 14 2024, 10:41
Reviewer
Restricted Project
Differential Revision
D16150: refactor: Move error() from util/system.h to logging.h
Parents
rABCffcb9d86e747: refactor: Extract util/exception from util/system
Branches
Unknown
Tags
Unknown