HomePhabricator

Make the Amount constructor noexcept

Description

Make the Amount constructor noexcept

Summary: Because it can't throw but that's not implied by constexpr. This fixes a build issue with clang8 that requires a noexcept constructor for the atomic, so we need that noexcept to build a std::atomic<Amount> which we do in net.h.

Test Plan:
With clang 8:

ninja all check

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D13803

Details

Provenance
FabienAuthored on Apr 27 2023, 08:58
FabienPushed on Apr 27 2023, 09:56
Reviewer
Restricted Project
Differential Revision
D13803: Make the Amount constructor noexcept
Parents
rABC8f624017f90e: build: split native_cctools
Branches
Unknown
Tags
Unknown