HomePhabricator

[chronik] Consistently sync the validation queue in functional tests

Description

[chronik] Consistently sync the validation queue in functional tests

Summary:
In several places in chronik tests, a peer send a block to the node and waits for the node to catch up before calling chronik. This is racy because it doesn't guarantee that the validation callbacks ran and chronik might not be synced yet. Fix this by consistently syncing the validation queue in these cases.
There are likely other similar edge cases but this should avoid most of the random (and rare) failures due to this race condition.

Test Plan:

./test/functional/test_runner.py chronik_*

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17675

Details

Provenance
FabienAuthored on Wed, Feb 19, 09:03
FabienPushed on Wed, Feb 19, 13:46
Reviewer
Restricted Project
Differential Revision
D17675: [chronik] Consistently sync the validation queue in functional tests
Parents
rABCc78d17424346: [avalanche] Deprecate the node availability score in the peerinfo RPC
Branches
Unknown
Tags
Unknown