HomePhabricator

[backport#16578] Do not pass in command line arguments to QApplication

Description

[backport#16578] Do not pass in command line arguments to QApplication

Summary:
a2714a5c69f0b0506689af04c3e785f71ee0915d Give QApplication dummy arguments (Andrew Chow)

Pull request description:

QApplication takes the command line arguments and parses them itself for some [built in command line arguments](https://doc.qt.io/qt-5/qapplication.html#QApplication) that it has. We don't want any of those built in arguments, so instead give it dummy arguments.

To test, you can use the `-reverse` option. Without this patch, everything will appear right-to-left; things that were on the left side will be on the right and everything is right aligned.

After this patch, `-reverse` will now give a startup error since we do not support this argument.

Backport of Core PR16578

Test Plan:

ninja all check check-functional

Check that bitcoin-qt -reverse -regtest gives an error with this patch and reverses the GUI without i.t

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D7747

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Aug 15 2019, 07:03
majcostaCommitted on Oct 2 2020, 19:00
majcostaPushed on Oct 2 2020, 19:00
Reviewer
Restricted Project
Differential Revision
D7747: [backport#16578] Do not pass in command line arguments to QApplication
Parents
rABCb3d60780c3a2: [backport#16554] test: only include and use OpenSSL where it's actually needed…
Branches
Unknown
Tags
Unknown