HomePhabricator

Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone

Description

Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone

Summary:

Instead of having these be class static functions, just make them be
standalone. Also removes WalletBatch::Recover which just passed through
to BerkeleyBatch::Recover.

Partial backport (8/11) of core PR18918:
https://github.com/bitcoin/bitcoin/pull/18918/commits/b426c7764d26e280e1f814cf36e050743c45cd12

Depends on D8594.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8595

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on May 15 2020, 23:24
FabienCommitted on Dec 7 2020, 08:34
FabienPushed on Dec 7 2020, 08:35
Reviewer
Restricted Project
Differential Revision
D8595: Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone
Parents
rABCf6e4ac7f8090: Expose a version of ReadKeyValue and use it in RecoverKeysOnlyFilter
Branches
Unknown
Tags
Unknown