HomePhabricator

test: Change feature_config_args.py not to rely on strange regtest=0 behavior

Description

test: Change feature_config_args.py not to rely on strange regtest=0 behavior

Summary:
Update test to simply generate a normal mainnet configuration file instead of
using a crazy setup where a regtest=1 config file using an includeconf in the
[regtest] section includes another config file that specifies regtest=0,
retroactively switching the network to mainnet.

This setup was fragile and only worked because the triggered InitError happened
early enough that none of the ignored [regtest] options mattered (only
affecting log output).

This is a backport of core#17556

Note that the extra disable_autoconnect is needed because core#22490 was backported before (D10966).

Test Plan: ninja check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D14395

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Nov 15 2019, 21:26
PiRKCommitted on Aug 22 2023, 11:38
PiRKPushed on Aug 22 2023, 11:38
Reviewer
Restricted Project
Differential Revision
D14395: test: Change feature_config_args.py not to rely on strange regtest=0 behavior
Parents
rABCbb2ac46df04e: Replace boost::variant with std::variant
Branches
Unknown
Tags
Unknown