HomePhabricator

Apply AreSane() checks to the fees from the network.
64849306905eUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Apply AreSane() checks to the fees from the network.

'Sane' was already defined by this code as:
fee.GetFeePerK() > minRelayFee.GetFeePerK() * 10000
But sanity was only enforced for data loaded from disk.

Note that this is a pretty expansive definition of 'sane': A 10 BTC
fee is still passes the test if its on a 100kb transaction.

This prevents a single insane fee on the network from making us reject
our stored fee data at start. We still may reject valid saved fee
state if minRelayFee is changed between executions.

This also reduces the risk and limits the damage from a cascading
failure where one party pays a bunch of insane fees which cases
others to pay insane fees.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Dec 15 2014, 22:38
deadalnixPushed on May 14 2017, 22:04
Parents
rABC13c077c7cfe9: Merge pull request #5471
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rABC64849306905e: Apply AreSane() checks to the fees from the network. (authored by Gregory Maxwell <greg@xiph.org>).Dec 15 2014, 22:50