HomePhabricator

rpc: Make verifychain default values static, not depend on global args

Description

rpc: Make verifychain default values static, not depend on global args

Summary:

This fixes several issues:

  • The documentation is not compile-time static and depends on run-time arguments, making it impossible to host it on a static resource like a website or pdf. See also a similar change in the wallet rpc code: #18499
  • The same call (relying on default values) will run different code on different machines, depending on the command line args that were used to start the server. This might lead to hard-to-debug-remote issues.

This is a backport of Core PR18541

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8911

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jan 14 2021, 16:11
PiRKCommitted on Jan 14 2021, 16:11
abc-botPushed on Jan 14 2021, 16:17
Reviewer
Restricted Project
Differential Revision
D8911: rpc: Make verifychain default values static, not depend on global args
Parents
rABCfbd564ae6a78: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled
Branches
Unknown
Tags
Unknown