HomePhabricator

[Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH.

Description

[Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH.TransactionBuilder references

Summary:
T2730

Depends on D12601

This diff deprecates the remaining use of BCH-JS' transaction builder and replaces it with the local implementation for the burnToken function and unit tests.

Pt 1/8 - Localize Transaction Builder module
Pt 2/8 - Deprecate BCH.TransactionBuilder in sendXec
Pt 3/8 - Add local TxBuilder to createToken
Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken
Pt 5/8 - Add local TxBuilder to sendToken
Pt 6/8 - Deprecate BCH.TransactionBuilder in sendToken
Pt 7/8 - Add local TxBuilder to burnToken
Pt 8/8 - Deprecate remaining BCH.TransactionBuilder references

Test Plan:

  • grep -r 'BCH.TransactionBuilder' src/ and ensure no results
  • npm ci
  • npm test and ensure no errors with txBuilder.test.js
  • npm start
  • burn an existing token and ensure burn token tx is successfully broadcasted
  • burn a newly created token and ensure burn token tx is successfully broadcasted
  • create a new token and ensure genesis tx is still successfully broadcasted
  • send an existing token and ensure send token tx is still successfully broadcasted
  • send a newly created token and ensure send token tx is still successfully broadcasted

Reviewers: bytesofman, #bitcoin_abc

Reviewed By: bytesofman, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D12602

Details

Provenance
emackAuthored on Nov 23 2022, 23:34
emackPushed on Nov 25 2022, 11:23
Reviewer
Restricted Project
Differential Revision
D12602: [Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH.TransactionBuilder references
Parents
rABC1bfa6a5f0204: [Cashtab] [BCH deprecation] [TxBuilder] Pt 7/8 - Add local TxBuilder to…
Branches
Unknown
Tags
Unknown