HomePhabricator

Merge #13061: Make tests pass after 2020

Authored by Wladimir J. van der Laan <laanwj@gmail.com> on Apr 24 2018, 11:23.

Description

Merge #13061: Make tests pass after 2020

Summary:
3ee4be1 Make tests pass after 2020 (Bernhard M. Wiedemann)

Pull request description:

Make tests pass after 2020
and also test that 64 bit integers are properly handled

Without this patch, the failure was
```
unknown location(0): fatal error: in "rpc_tests/rpc_ban": std::runtime_error: JSON value is not an object as expected
test/rpc_tests.cpp(260): last checkpoint
```

I found this when testing reproducible builds for openSUSE Linux packages, building 15 years from now (this is the expected lifespan of today's software)

There is 1 other issue in ./src/qt/test/paymentservertests.cpp that fails to verify a cert that expires in 2022 after 10y.

```
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: Payment request: certificate expired or not yet active:  QSslCertificate("3", "01", "Ipbt+DxK8RDQd25/5ueXqw==", (), ("Payment Request Test Merchant"), QMap(), QDateTime(2012-12-10 16:37:24.000 UTC Qt::TimeSpec(UTC)), QDateTime(2022-12-08 16:37:24.000 UTC Qt::TimeSpec(UTC)))
FAIL!  : PaymentServerTests::paymentServerTests() Compared values are not the same
```

Tree-SHA512: d6c49879b6abbddbecc1168ac24c2d4f4ee9949b615607b3e6ba350c415136017f32cd112708791b063a2f2dc1b12f295f4ee55a346bd2128aa6480088d8db48

Backport of Core PR13061

Test Plan:

faketime '2022-01-01' ninja check-bitcoin-rpc_tests

Fails pre-patch, passes post-patch

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5569

Details

Committed
jasonbcoxWed, Mar 25, 21:11
Pushed
jasonbcoxWed, Mar 25, 21:11
Reviewer
Restricted Project
Differential Revision
D5569: Merge #13061: Make tests pass after 2020
Parents
rABC3a84ae8b0c04: Partial Merge #14726: Use RPCHelpMan for all RPCs
Branches
Unknown
Tags
Unknown

Event Timeline