HomePhabricator

lint: Add std::locale::global to list of locale dependent functions

Description

lint: Add std::locale::global to list of locale dependent functions

Summary:

We currently flag setlocale(...) as locale dependent, but prior to this commit we didn't flag
std::locale::global(...) as such.

In addition to setting the global C++ locale std::locale::global(...) also does the equivalent
of std::setlocale(LC_ALL, ...);.

Thus the functionality of std::locale::global(...) is a superset of setlocale(...) :)

This is a backport of core#18649

Test Plan: arc lint --everything

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9977

Details

Provenance
PiRKAuthored on Aug 30 2021, 13:08
PiRKPushed on Aug 30 2021, 14:24
Reviewer
Restricted Project
Differential Revision
D9977: lint: Add std::locale::global to list of locale dependent functions
Parents
rABCa33b200ef621: refactor: Remove confusing OutputType::CHANGE_AUTO
Branches
Unknown
Tags
Unknown