Paths

Table of Contentst

Diffusion Bitcoin ABC 699427a1af8d

[Cashtab] Convert `balance` to string throughout app
699427a1af8d
Actions

Description

[Cashtab] Convert balance to string throughout app

Summary:
T2600

Depends on D11875

Test Plan:
npm test

npm start and confirm app functions as before:

Check the XEC and fiat balance displays on every screen and verify they match cashtab.com

Reviewers: #bitcoin_abc, kieran709

Reviewed By: #bitcoin_abc, kieran709

Differential Revision: https://reviews.bitcoinabc.org/D11876

Details

Provenance

bytesofman	Authored on Aug 18 2022, 21:51
bytesofman	Pushed on Aug 22 2022, 23:41

Reviewer

Restricted Project

Differential Revision

D11876: [Cashtab] Convert `balance` to string throughout app

Parents

rABCe677025c4d76: [Cashtab] Match return type in unit conversion functions

Branches

Unknown

Tags

Unknown

Event Timeline

bytesofman committed rABC699427a1af8d: [Cashtab] Convert `balance` to string throughout app (authored by bytesofman).Aug 22 2022, 23:40

bytesofman added an edge: D11876: [Cashtab] Convert `balance` to string throughout app.

teamcity mentioned this in T2619: Build Bitcoin-ABC / Master / Coverage is broken..Aug 23 2022, 00:28

Changes (8)

Path

Size

web/

cashtab/

src/

components/

Common/

BalanceHeader.js

BalanceHeaderFiat.js

Home/

__mocks__/

walletAndBalancesMock.js

Tokens/

Tokens.js

__tests__/

CreateTokenForm.test.js

utils/

__mocks__/

mockCachedUtxos.js

mockStoredWallets.js

cashMethods.js

rABC699427a1af8d

View Options

web/cashtab/src/components/Common/BalanceHeader.js

View Options

web/cashtab/src/components/Common/BalanceHeaderFiat.js

View Options

web/cashtab/src/components/Home/mocks/walletAndBalancesMock.js

View Options

web/cashtab/src/components/Tokens/Tokens.js

View Options

web/cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

View Options

web/cashtab/src/utils/mocks/mockCachedUtxos.js

View Options

web/cashtab/src/utils/mocks/mockStoredWallets.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] Convert `balance` to string throughout app699427a1af8dActions

Description

Details

Event Timeline

Changes (8)

rABC699427a1af8d

web/cashtab/src/components/Common/BalanceHeader.js

web/cashtab/src/components/Common/BalanceHeaderFiat.js

web/cashtab/src/components/Home/__mocks__/walletAndBalancesMock.js

web/cashtab/src/components/Tokens/Tokens.js

web/cashtab/src/components/Tokens/__tests__/CreateTokenForm.test.js

web/cashtab/src/utils/__mocks__/mockCachedUtxos.js

web/cashtab/src/utils/__mocks__/mockStoredWallets.js

web/cashtab/src/utils/cashMethods.js

[Cashtab] Convert `balance` to string throughout app
699427a1af8d
Actions

web/cashtab/src/components/Home/mocks/walletAndBalancesMock.js

web/cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

web/cashtab/src/utils/mocks/mockCachedUtxos.js

web/cashtab/src/utils/mocks/mockStoredWallets.js