HomePhabricator

[Cashtab] Improve and simplify fiat API

Description

[Cashtab] Improve and simplify fiat API

Summary:
We should always throw an error if we do not get a good price. The "double" try...catch is not necessary.

Part of the codebase that has not been changed for years, implementing better practices. Also bumping the interval as 60s was resulting in rate limits.

Test Plan: npm test

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Subscribers: PiRK

Differential Revision: https://reviews.bitcoinabc.org/D15700

Details

Provenance
bytesofmanAuthored on Mar 14 2024, 16:36
bytesofmanPushed on Mar 14 2024, 17:43
Reviewer
Restricted Project
Differential Revision
D15700: [Cashtab] Improve and simplify fiat API
Parents
rABC623004961ac4: [mock-chronik-client] Match shape of subs in ws to ChronikClientNode for…
Branches
Unknown
Tags
Unknown