Factor out outpoint generation in transaction_tests.cpp

Summary: As per title. Also properly use TxId.

Test Plan:

make check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D3643