HomePhabricator

Update qt/bitcoingui with Qt5 connect syntax

Description

Update qt/bitcoingui with Qt5 connect syntax

Summary:
Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-0db7dd184df07a48c307ccc182021a68

Test Plan:

make check
./bitcoin-qt
Send -> Receive -> Transactions
File -> Sending Addresses
File -> Receiving Addresses
Settings -> Options
Help -> Debug

Verify every sub menu and window opens and loads correctly.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4338

Details

Provenance
nakihitoAuthored on Oct 31 2019, 00:27
nakihitoPushed on Oct 31 2019, 19:22
Reviewer
Restricted Owners Package
Differential Revision
D4338: Update qt/bitcoingui with Qt5 connect syntax
Parents
rABCfc49fe70e9bf: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled
Branches
Unknown
Tags
Unknown